xfs
[Top] [All Lists]

Re: [PATCH 0/5] refactor the preallocation and hole punching code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/5] refactor the preallocation and hole punching code
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 21 Oct 2013 16:58:25 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hi Christoph,

On Sat, Oct 12, 2013 at 12:55:03AM -0700, Christoph Hellwig wrote:
> This series massages the preallocation and hole punching code into something
> sane.  The big catchall xfs_change_file_space function is gone, fallocate
> and the ioctl entry point now directly call the low-level functions, and
> fallocate can avoid packing its arguments into the xfs_flock form and
> duplicating error checking already done in the VFS.  In addition we also
> use a common locking patter now, that is preallocations using the ioctl
> path now also take iolock, just like fallocate and all other ioctl cases
> already did beforehand.
> 
> 
> Changes since version 1:
>  - remove the unused setprealloc variable in xfs_file_fallocate
>  - rebased

Applied this series.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>