xfs
[Top] [All Lists]

Re: [PATCH 5/8] xfstests: generic/274 increase scratch fs size to 2g

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH 5/8] xfstests: generic/274 increase scratch fs size to 2g
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Mon, 21 Oct 2013 10:29:39 -0500
Cc: linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1382120790-31060-5-git-send-email-jbacik@xxxxxxxxxxxx>
References: <1382120790-31060-1-git-send-email-jbacik@xxxxxxxxxxxx> <1382120790-31060-5-git-send-email-jbacik@xxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/18/13 1:26 PM, Josef Bacik wrote:
> With 1 gig btrfs defaults to mixed block groups, so we ENOSPC in this test
> because we run out of metadata space, not data space.  Increasing to 2g allows
> us to use our normal setup and allows us to pass this test.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>

Doubles the test time on xfs, but from 16s to 30s on a single spindle sata
disk; I think we can handle it.

ext4 fails w/ or w/o the patch, so *shrug*

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  tests/generic/274 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/274 b/tests/generic/274
> index da45fab..7c4887f 100755
> --- a/tests/generic/274
> +++ b/tests/generic/274
> @@ -57,7 +57,7 @@ echo "------------------------------"
>  rm -f $seqres.full
>  
>  umount $SCRATCH_DEV 2>/dev/null
> -_scratch_mkfs_sized $((1 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
> +_scratch_mkfs_sized $((2 * 1024 * 1024 * 1024)) >>$seqres.full 2>&1
>  _scratch_mount
>  
>  # Create a 4k file and Allocate 4M past EOF on that file
> 

<Prev in Thread] Current Thread [Next in Thread>