xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests: Test xfs_fsr / swapext management of di_forkoff

To: Eryu Guan <guaneryu@xxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: Test xfs_fsr / swapext management of di_forkoff w/ selinux
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 18 Oct 2013 12:27:26 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131018172635.GE11404@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <5260B62D.2010507@xxxxxxxxxx> <52616072.6040808@xxxxxxxxxxx> <20131018172635.GE11404@xxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/18/13 12:26 PM, Eryu Guan wrote:

...

> There's trailing whitespaces issue here, otherwise looks good to me.
> 
> I suppose the seq number can be fixed at commit time, as well as the
> trailing whitespaces.
> 
> Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx>
> 
> Thanks!
> Eryu
> 
> BTW, test fails on 3.12-rc5 kernel

Yup.  (actually it's a userspace bug)

-Eric

<Prev in Thread] Current Thread [Next in Thread>