xfs
[Top] [All Lists]

Re: [PATCH 6/6] xfstests: add a multithreaded mode to bstat

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfstests: add a multithreaded mode to bstat
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 17 Oct 2013 22:39:57 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131018030039.GS4446@dastard>
References: <1370610398-14630-1-git-send-email-david@xxxxxxxxxxxxx> <1370610398-14630-7-git-send-email-david@xxxxxxxxxxxxx> <526056AC.4000307@xxxxxxxxxxx> <20131018030039.GS4446@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/17/13 10:00 PM, Dave Chinner wrote:
> On Thu, Oct 17, 2013 at 04:29:16PM -0500, Eric Sandeen wrote:
>> On 6/7/13 8:06 AM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>>
>>> For benchmarking of bulkstat, add a multithreaded mode that spawns a
>>> thread per AG and runs bulkstat on every AG in parallel. There is a
>>> small amount of overlap between each AG because of the way the
>>> interface works only on inode numbers, so some inodes are reported
>>> twice. A real implementation of this sort of parallelism would be
>>> greatly helped by adding an AG parameter to the bulkstat interface.
>>>
>>> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
>>
>> At least w/ older xfsprogs[[qa]-devel] packages, I get:
>>
>> bstat.c:41: error: redefinition of 'fls'
>> /usr/include/xfs/bitops.h:8: note: previous definition of 'fls' was here
>> bstat.c:70: error: redefinition of 'xfs_highbit32'
>> /usr/include/xfs/xfs_bit.h:50: note: previous definition of 'xfs_highbit32' 
>> was here
>>
>> w/ the new functions you've added here...
> 
> Ok, so I need autoconf magic here to detect this?

seems that way.  TBH I don't *cough* have a box w/ latests xfsprogs headers 
installed
currently, so didn't see exactly what changed...

-Eric

> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>