xfs
[Top] [All Lists]

Re: [PATCH 6/6] xfstests: add a multithreaded mode to bstat

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfstests: add a multithreaded mode to bstat
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 18 Oct 2013 14:00:40 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <526056AC.4000307@xxxxxxxxxxx>
References: <1370610398-14630-1-git-send-email-david@xxxxxxxxxxxxx> <1370610398-14630-7-git-send-email-david@xxxxxxxxxxxxx> <526056AC.4000307@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 17, 2013 at 04:29:16PM -0500, Eric Sandeen wrote:
> On 6/7/13 8:06 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > For benchmarking of bulkstat, add a multithreaded mode that spawns a
> > thread per AG and runs bulkstat on every AG in parallel. There is a
> > small amount of overlap between each AG because of the way the
> > interface works only on inode numbers, so some inodes are reported
> > twice. A real implementation of this sort of parallelism would be
> > greatly helped by adding an AG parameter to the bulkstat interface.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> At least w/ older xfsprogs[[qa]-devel] packages, I get:
> 
> bstat.c:41: error: redefinition of 'fls'
> /usr/include/xfs/bitops.h:8: note: previous definition of 'fls' was here
> bstat.c:70: error: redefinition of 'xfs_highbit32'
> /usr/include/xfs/xfs_bit.h:50: note: previous definition of 'xfs_highbit32' 
> was here
> 
> w/ the new functions you've added here...

Ok, so I need autoconf magic here to detect this?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>