xfs
[Top] [All Lists]

Re: [PATCH 5/6] xfstests: New _require_* tests for CRC enabled filesyste

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfstests: New _require_* tests for CRC enabled filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 18 Oct 2013 13:58:19 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5260557D.8050404@xxxxxxxxxxx>
References: <1370610398-14630-1-git-send-email-david@xxxxxxxxxxxxx> <1370610398-14630-6-git-send-email-david@xxxxxxxxxxxxx> <5260557D.8050404@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 17, 2013 at 04:24:13PM -0500, Eric Sandeen wrote:
> On 6/7/13 8:06 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > CRCs always enabled 32 bit project inodes and attr2 formats, hence
> > they cannot be turned off. Add new require rules for the tests that
> > require attr and 16 bit project IDs so these tests are avoided on
> > CRC enabled filesystems.
> > 
> > Also, add a xfs_db write check so that we can avoid tests that are
> > dependent on xfs_db modifying filesystem structures as they will
> > fail on CRC enabled filessystems right now. This is just temporary
> > until full write xfs_db support is available.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> small optimization question below

Using -N makes sense. I forgot about that option :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>