xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 17 Oct 2013 16:17:40 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131017200315.GA26616@xxxxxxxxxxxxx>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.115410017@xxxxxxxxxxxxxxxxxxxxxx> <20131014045152.GG4446@dastard> <20131017200109.GI1935@xxxxxxx> <20131017200315.GA26616@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Christoph,

On Thu, Oct 17, 2013 at 01:03:15PM -0700, Christoph Hellwig wrote:
> On Thu, Oct 17, 2013 at 03:01:09PM -0500, Ben Myers wrote:
> > An xfs ioctl user who requests nonblocking behavior will no longer get it.
> > This seems to constitute API breakage.  How can we verify that this is 
> > unused
> > since anyone can open with O_NONBLOCK?
> 
> The flag isn't checked anywhere, which means it doesn't have any effect,
> and doesn't as far as I can look back.

Gah.  I was about to say that you just removed the last usage of it in patch 1!
But that patch is about NOLOCK, not NONBLOCK.  I should get my eyes checked. ;)

Anyway, XFS_ATTR_NONBLOCK is used by dmapi so that nfs threads don't block for
offline files.  Folks who care about that sort of thing will have to add it
back in.  That's fine.

FWIW, you can see that here:
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs.git;a=shortlog;h=refs/heads/v3.0-xfs_dmapi

> I also don't know how the
> prealloc ioctls could behave non-blocking in any sane way.

Right.  Nfsd doesn't use any of those ioctls, so I don't really see the point
either.

Looks like my concern was unfounded.

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>