xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 17 Oct 2013 13:03:15 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131017200109.GI1935@xxxxxxx>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.115410017@xxxxxxxxxxxxxxxxxxxxxx> <20131014045152.GG4446@dastard> <20131017200109.GI1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 17, 2013 at 03:01:09PM -0500, Ben Myers wrote:
> An xfs ioctl user who requests nonblocking behavior will no longer get it.
> This seems to constitute API breakage.  How can we verify that this is unused
> since anyone can open with O_NONBLOCK?

The flag isn't checked anywhere, which means it doesn't have any effect,
and doesn't as far as I can look back.  I also don't know how the
prealloc ioctls could behave non-blocking in any sane way.

<Prev in Thread] Current Thread [Next in Thread>