xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag

To: Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 17 Oct 2013 15:01:09 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131014045152.GG4446@dastard>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.115410017@xxxxxxxxxxxxxxxxxxxxxx> <20131014045152.GG4446@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
Gents,

On Mon, Oct 14, 2013 at 03:51:52PM +1100, Dave Chinner wrote:
> On Sat, Oct 12, 2013 at 12:55:05AM -0700, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Still unused after all this time, so removing it is fine by me.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

An xfs ioctl user who requests nonblocking behavior will no longer get it.
This seems to constitute API breakage.  How can we verify that this is unused
since anyone can open with O_NONBLOCK?

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>