xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfsprog: add mkfs.xfs sb v4 support for dirent filetype field
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 17 Oct 2013 08:26:03 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131016235033.GN4446@dastard>
References: <20131016223654.505433792@xxxxxxx> <20131016223812.698179281@xxxxxxx> <20131016235033.GN4446@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 10/16/13 18:50, Dave Chinner wrote:
On Wed, Oct 16, 2013 at 05:36:57PM -0500, Mark Tinguely wrote:
Add directory inode type feature to mkfs.xfs and its manual page.

In sb v4, "mkfs.xfs -n ftype=1" turns on the feature. The feature is
still automatically turned on for sb v5. Reject the "ftype=1" request
if used with the "crc=1" setting.

Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
---

+
        sbp->sb_features2 = XFS_SB_VERSION2_MKFS(crcs_enabled, lazy_sb_counters,
-                                       attrversion == 2, !projid16bit, 0);
+                                  attrversion == 2, !projid16bit, 0,
+                                  (crcs_enabled && dirftype));

Eek that change was made yesterday and should be:
 (!crcs_enabled && dirftype)
so the feature bit is only turned on for v4 sb.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>