xfs
[Top] [All Lists]

Re: [PATCH 19/19] xfs: convert directory vector functions to constants

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 19/19] xfs: convert directory vector functions to constants
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 17 Oct 2013 09:23:17 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131016211615.GD1935@xxxxxxx>
References: <1381789085-21923-1-git-send-email-david@xxxxxxxxxxxxx> <1381789085-21923-20-git-send-email-david@xxxxxxxxxxxxx> <20131016211615.GD1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 16, 2013 at 04:16:15PM -0500, Ben Myers wrote:
> On Tue, Oct 15, 2013 at 09:18:05AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Many of the vectorised function calls now take no parameters and
> > return a constant value. There is no reason for these to be vectored
> > functions, so convert them to constants
> > 
> > Binary sizes:
> > 
> >    text    data     bss     dec     hex filename
> >  794490   96802    1096  892388   d9de4 fs/xfs/xfs.o.orig
> >  792986   96802    1096  890884   d9804 fs/xfs/xfs.o.p1
> >  792350   96802    1096  890248   d9588 fs/xfs/xfs.o.p2
> >  789293   96802    1096  887191   d8997 fs/xfs/xfs.o.p3
> >  789005   96802    1096  886903   d8997 fs/xfs/xfs.o.p4
> >  789061   96802    1096  886959   d88af fs/xfs/xfs.o.p5
> >  789733   96802    1096  887631   d8b4f fs/xfs/xfs.o.p6
> >  791421   96802    1096  889319   d91e7 fs/xfs/xfs.o.p7
> >  791701   96802    1096  889599   d92ff fs/xfs/xfs.o.p8
> >  791205   96802    1096  889103   d91cf fs/xfs/xfs.o.p9
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Hmmm.  This one doesn't seem to apply.  Maybe it's just me.

Applies without mismatch here on an 3.12-rc5 + oss-xfs/master tree
here. What's the reject that you get?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>