xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: add specific test for default ACL inheritance

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: add specific test for default ACL inheritance
From: Filipe David Manana <fdmanana@xxxxxxxxx>
Date: Wed, 16 Oct 2013 17:11:26 +0100
Cc: "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Josef Bacik <jbacik@xxxxxxxxxxxx>, "dsterba@xxxxxxx" <dsterba@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=8Bbg4ANl+Az5ZkDqzZFQH0V8xmh5UYxxS1L4fmCG9ms=; b=BtcOAiKelrfsUBSeb328qAk/i1G1aKB3ByF3p+xbnI10K2gcf33mQDsjfj/3tZTrsy ewGHzrCHVKfF+EXxrxjoEPgeEZaNXOaixHNxuA1ljY6RJs5shY8h9QFikdgM0Qc7B3ey rfeOuwyvSn69n1ihXDyvVEZbCR/+sA855ZtJFXzX6k2LbrLzwDp/n0AI6q29dIIXMSg9 3PucD8SREZWF+BWJIbfdsJ4bNVoLqcHIBcfxVCkEYOgFSh37r4PjVpZl79Br7UioXWOM 4MtRgnYbH+4/7A9jI5hCC3kc3XSsfeKNfrRMt3UWPocdxeNLYoepsHyxDgYcvE1KPvmu oA5Q==
In-reply-to: <525EBA40.4020401@xxxxxxxxxxx>
References: <1381932296-14674-1-git-send-email-fdmanana@xxxxxxxxx> <1381938761-31625-1-git-send-email-fdmanana@xxxxxxxxx> <525EBA40.4020401@xxxxxxxxxxx>
Reply-to: fdmanana@xxxxxxxxx
On Wed, Oct 16, 2013 at 5:09 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
> On 10/16/13 10:52 AM, Filipe David Borba Manana wrote:
>> This test is motivated by an issue found by a btrfs user, addressed
>> and described by the following GNU/Linux kernel patch:
>>
>> https://patchwork.kernel.org/patch/3046931/
>>
>> The steps to reproduce the issue on btrfs are the following:
>>
>> $ mkfs.btrfs -f /dev/loop0
>> $ mount /dev/loop0 /mnt
>> $ mkdir /mnt/acl
>> $ setfacl -d --set u::rwx,g::rwx,o::- /mnt/acl
>> $ getfacl /mnt/acl
>> user::rwx
>> group::rwx
>> other::r-x
>> default:user::rwx
>> default:group::rwx
>> default:other::---
>>
>> $ mkdir /mnt/acl/dir1
>> $ getfacl /mnt/acl/dir1
>> user::rwx
>> group::rwx
>> other::---
>>
>> After unmounting and mounting again the filesystem, getfacl returned the
>> expected default ACL for the subdirectory:
>>
>> $ umount /mnt/acl
>> $ mount /dev/loop0 /mnt
>> $ getfacl /mnt/acl/dir1
>> user::rwx
>> group::rwx
>> other::---
>> default:user::rwx
>> default:group::rwx
>> default:other::---
>>
>> This means that the underlying ACL xattr was persisted correctly but
>> the in memory representation of the inode had (incorrectly) a NULL ACL.
>>
>> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
>> ---
>>
>> V2: Moved the regression test into a dedicated and new file, as suggested
>>     by Eric Sandeen.
>
> Great, thanks.  Verified that it succeeds on xfs & ext3 as well.
>
> It also fails properly when mounting ext3 -o noacl:
>
> shared/052 1s ... [not run] ACLs not supported by this filesystem type: ext3
>
> ...
>
>> +# real QA test starts here
>> +_supported_os Linux
>
> Technically this should have a:
>
> +_supported_fs generic
>
> here.  And then it can move to tests/generic/xxx
>
> (I guess that's a little odd and redundant, and it does
> run today w/o the _supported_fs, I guess, but still
> best to be consistent).
>
> Sorry for the runaround :)
>
> If you don't mind a V3, we'll be done,  I think!

Np.
Is there any rule as for which name (number) to pick for the test case
file name?

>
> -Eric
>



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

<Prev in Thread] Current Thread [Next in Thread>