xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Oct 2013 00:03:33 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131015214733.GW4446@dastard>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.637625757@xxxxxxxxxxxxxxxxxxxxxx> <20131014050807.GJ4446@dastard> <20131015153143.GA1612@xxxxxxxxxxxxx> <20131015214733.GW4446@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 16, 2013 at 08:47:33AM +1100, Dave Chinner wrote:
> I'll put a significant quantity of beer on the table if anyone other
> than xfstests is actually using these ioctls. In all my years of
> working with XFS, I've never seen a single user of them, even on
> Irix.
> 
> The one person I know who was considering using XFS_IOC_ALLOCSP
> convinced me (quite easily) to implement XFS_IOC_ZERO_RANGE for them
> because writing all those zeros to re-initialise pre-allocated VM
> images was going to be prohibitively expensive...
> 
> Anyway, it was just a thought.

Send a patch to warn on their usage, and you might be the lucky owner of
a beer or two a few years down the road :)

<Prev in Thread] Current Thread [Next in Thread>