xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfs: reject completely bogus remount options

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfs: reject completely bogus remount options
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Tue, 15 Oct 2013 13:13:12 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131014044501.GE4446@dastard>
References: <52584C8A.1060808@xxxxxxxxxx> <52584D56.7090902@xxxxxxxxxxx> <20131013215208.GE5663@dastard> <525B5A1D.90706@xxxxxxxxxxx> <20131014044501.GE4446@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/13/13 11:45 PM, Dave Chinner wrote:
> On Sun, Oct 13, 2013 at 09:42:37PM -0500, Eric Sandeen wrote:
>> On 10/13/13 4:52 PM, Dave Chinner wrote:
>>> On Fri, Oct 11, 2013 at 02:11:18PM -0500, Eric Sandeen wrote:
>>>> There's a long comment about handling non-remountable
>>>> options in xfs_fs_remount, but nothing addresses the case
>>>> of completely bogus mount options at remount time, which
>>>> can lead to some severe strangeness:
>>>>
>>>> # for I in `seq 1 10`; do mount -o remount,noacl /mnt/test2; done
>>>> # for I in `seq 1 10`; do mount -o remount,badoption /mnt/test2; done

I'm going to just drop this patch for now; it seems too hacky.

really, mount option handling just needs a big rework.

-Eric

<Prev in Thread] Current Thread [Next in Thread>