xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 15 Oct 2013 08:31:43 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131014050807.GJ4446@dastard>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.637625757@xxxxxxxxxxxxxxxxxxxxxx> <20131014050807.GJ4446@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 14, 2013 at 04:08:07PM +1100, Dave Chinner wrote:
> One question, though:
> 
> > +   case XFS_IOC_ALLOCSP:
> > +   case XFS_IOC_ALLOCSP64:
> > +   case XFS_IOC_FREESP:
> > +   case XFS_IOC_FREESP64:
> 
> Should we, at this point, mark these ioctls as deprecated and
> schedule then for removal given that we've recommended against using
> them for the past 10 years and we have fallocate() now?

I don't see any reason to remove them given that it's only about 15
extra lines of code.  But if you care enough to get rid of them we
probably need multiple years of actuall warnings emmited when used
before actually removing them.  I would be very surprised if there
aren't same users that wouldn't argue very vocally against their
removal.

<Prev in Thread] Current Thread [Next in Thread>