xfs
[Top] [All Lists]

Re: [PATCH] xfs: prevent deadlock trying to cover an active log

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: prevent deadlock trying to cover an active log
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 14 Oct 2013 15:36:23 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131014202234.GO4446@dastard>
References: <1381278703-23439-1-git-send-email-david@xxxxxxxxxxxxx> <52577337.2090901@xxxxxxxxxxx> <20131014200422.GA1935@xxxxxxx> <20131014202234.GO4446@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 15, 2013 at 07:22:34AM +1100, Dave Chinner wrote:
> On Mon, Oct 14, 2013 at 03:04:22PM -0500, Ben Myers wrote:
> > Hey Fellas,
> > > > diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> > > > index 136654b..de24ffb 100644
> > > > --- a/fs/xfs/xfs_log_priv.h
> > > > +++ b/fs/xfs/xfs_log_priv.h
> > > > @@ -514,12 +514,10 @@ xlog_assign_grant_head(atomic64_t *head, int 
> > > > cycle, int space)
> > > >  /*
> > > >   * Committed Item List interfaces
> > > >   */
> > > > -int
> > > > -xlog_cil_init(struct xlog *log);
> > > > -void
> > > > -xlog_cil_init_post_recovery(struct xlog *log);
> > > > -void
> > > > -xlog_cil_destroy(struct xlog *log);
> > > > +int    xlog_cil_init(struct xlog *log);
> > > > +void   xlog_cil_init_post_recovery(struct xlog *log);
> > > > +void   xlog_cil_destroy(struct xlog *log);
> > > > +bool   xlog_cil_empty(struct xlog *log)
> > 
> > Huh.  Looks like we're short a semicolon here.  I can add one, unless you
> > prefer to repost?
> 
> \o/
> 
> Someone finally noticed I sent a broken patch.
> 
> I forgot to refresh the commit before I sent it, so this was fixed
> before I even posted it. :/
> 
> Current version of the patch is below.

We'll take this one then.  ;)

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>