| To: | Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH RESEND V2] xfstests: Incorrect check for gdbm/ndbm.h |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 15 Oct 2013 07:09:35 +1100 |
| Cc: | xfs@xxxxxxxxxxx, vasily.isaenko@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1381762899-6799-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx> |
| References: | <20131013215708.GF5663@dastard> <1381762899-6799-1-git-send-email-stanislav.kholmanskikh@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Oct 14, 2013 at 07:01:39PM +0400, Stanislav Kholmanskikh wrote:
> Current version of AC_PACKAGE_WANT_NDBM has following bugs:
> * a typo (',') next to 'gdbm/ndbm.h', so C compiler fails
> with a syntax error when trying to compile
> "#include <gdbm/ndbm.h,>"
>
> * autoconf never defines HAVE_GDBM_NDBM_H_ because it
> converts both header names (gdbm/ndbm.h, gdbm-ndbm.h)
> to GDBM_NDBM_H
>
> Because of these bugs 'dbtest' can't be compiled on systems where
> 'gdbm-ndbm.h' header is absent but 'gdbm/ndbm.h' is present.
>
> Fixed this.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>
Looks good now.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfs_repair deletes files after power cut, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] libxfs: stop caching inode structures, Dave Chinner |
| Previous by Thread: | [PATCH RESEND V2] xfstests: Incorrect check for gdbm/ndbm.h, Stanislav Kholmanskikh |
| Next by Thread: | Re: [PATCH RESEND V2] xfstests: Incorrect check for gdbm/ndbm.h, Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |