xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: always take the iolock around xfs_setattr_size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 14 Oct 2013 00:29:43 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131014045007.GF4446@dastard>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075639.940898263@xxxxxxxxxxxxxxxxxxxxxx> <20131014045007.GF4446@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 14, 2013 at 03:50:07PM +1100, Dave Chinner wrote:
> I think there should be a bit more cleanup of this lock_flags
> variable. There's quite a few error paths that now "goto out_unlock"
> without actually holding a lock. i.e. they could just become a
> straight "return error", and lock_flags can probably go away
> completely...

I'll look into that.

<Prev in Thread] Current Thread [Next in Thread>