xfs
[Top] [All Lists]

Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 14 Oct 2013 16:08:07 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131012075640.637625757@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.637625757@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Oct 12, 2013 at 12:55:08AM -0700, Christoph Hellwig wrote:
> Now that only one caller of xfs_change_file_space is left it can be merged
> into said caller.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

One question, though:

> +     case XFS_IOC_ALLOCSP:
> +     case XFS_IOC_ALLOCSP64:
> +     case XFS_IOC_FREESP:
> +     case XFS_IOC_FREESP64:

Should we, at this point, mark these ioctls as deprecated and
schedule then for removal given that we've recommended against using
them for the past 10 years and we have fallocate() now?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>