[Top] [All Lists]

Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 14 Oct 2013 15:55:05 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131012075640.290849068@xxxxxxxxxxxxxxxxxxxxxx>
References: <20131012075503.370510641@xxxxxxxxxxxxxxxxxxxxxx> <20131012075640.290849068@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Oct 12, 2013 at 12:55:06AM -0700, Christoph Hellwig wrote:
> Currently fallocate always holds the iolock when calling into
> xfs_change_file_space, while the ioctl path lets some of the lower level
> functions take it, but leave it out in others.
> This patch makes sure the ioctl path also always holds the iolock and
> thus introduces consistent locking for the preallocation operations while
> simplifying the code and allowing to kill the now unused XFS_ATTR_NOLOCK
> flag.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>