xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: remove newlines from 3 xfs_alert_tag error strings

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 1/4] xfs: remove newlines from 3 xfs_alert_tag error strings
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 11 Oct 2013 20:45:45 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <525874AA.9020300@xxxxxxx>
References: <52584C8A.1060808@xxxxxxxxxx> <52584D04.3020907@xxxxxxxxxxx> <525874AA.9020300@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/11/13 4:59 PM, Mark Tinguely wrote:
> On 10/11/13 14:09, Eric Sandeen wrote:
>> xfs_alert_tag passes the format string to __xfs_printk,
>> which adds its own "\n".  Having it in the original string
>> leads to unintentional blank lines from these messages.
>>
>> Most format strings have no newline, but these 3 do, leading to
>> i.e.:
>>
>> [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 
>> start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05
>> [ 7347.119911]
>> [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 
>> start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05
>> [ 7347.119919]
>>
>> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
>> Reviewed-by: Carlos Maiolino<cmaiolino@xxxxxxxxxx>
>> ---
> 
> Is this true of xfs_alert() too? ie the newline in xfs_alert in 
> xfs_dir2_leafn_rebalance(). The newline in xfs_alert() in 
> xlog_unpack_data_crc() looks intentional.

All of these:

define_xfs_printk_level(xfs_emerg, KERN_EMERG);
define_xfs_printk_level(xfs_alert, KERN_ALERT);
define_xfs_printk_level(xfs_crit, KERN_CRIT);
define_xfs_printk_level(xfs_err, KERN_ERR);
define_xfs_printk_level(xfs_warn, KERN_WARNING);
define_xfs_printk_level(xfs_notice, KERN_NOTICE);
define_xfs_printk_level(xfs_info, KERN_INFO);
#ifdef DEBUG
define_xfs_printk_level(xfs_debug, KERN_DEBUG);
#endif

go through __xfs_printk(), which adds a newline...

seems like more fixes are in order, yeah.

-Eric
> --Mark.
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>