xfs
[Top] [All Lists]

Re: [PATCH 04/32] xfs: check magic numbers in dir3 leaf verifier first

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/32] xfs: check magic numbers in dir3 leaf verifier first
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 09 Oct 2013 15:50:47 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131009204527.GJ4446@dastard>
References: <1380510944-8571-1-git-send-email-david@xxxxxxxxxxxxx> <1380510944-8571-5-git-send-email-david@xxxxxxxxxxxxx> <52548F4F.5000800@xxxxxxxxxxx> <20131009204527.GJ4446@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/9/13 3:45 PM, Dave Chinner wrote:
> On Tue, Oct 08, 2013 at 06:03:43PM -0500, Eric Sandeen wrote:
>> On 9/29/13 10:15 PM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>>
>>> Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
>>> validating the magic numbers in the buffer results in ASSERT
>>> failures due to mismatching magic numbers when a corruption occurs.
>>> Seeing as the verifier is supposed to catch the corruption and pass
>>> it back to the caller, having the verifier assert fail on error
>>> defeats the purpose of detecting the errors in the first place.
>>>
>>> Check the magic numbers direct from the buffer before decoding the
>>> header.
>>
>> Looks good; have you sent this for the kernel yet?
>>
>> (I thought we wanted changes to hit kernelspace first) :)
> 
> Yes, commit 0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f.

Sorry I missed that, man, I swear I looked.

-Eric

> Cheers,
> 
> Dave.
> 

<Prev in Thread] Current Thread [Next in Thread>