xfs
[Top] [All Lists]

Re: [PATCH 04/32] xfs: check magic numbers in dir3 leaf verifier first

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 04/32] xfs: check magic numbers in dir3 leaf verifier first
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 10 Oct 2013 07:45:27 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52548F4F.5000800@xxxxxxxxxxx>
References: <1380510944-8571-1-git-send-email-david@xxxxxxxxxxxxx> <1380510944-8571-5-git-send-email-david@xxxxxxxxxxxxx> <52548F4F.5000800@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 08, 2013 at 06:03:43PM -0500, Eric Sandeen wrote:
> On 9/29/13 10:15 PM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
> > validating the magic numbers in the buffer results in ASSERT
> > failures due to mismatching magic numbers when a corruption occurs.
> > Seeing as the verifier is supposed to catch the corruption and pass
> > it back to the caller, having the verifier assert fail on error
> > defeats the purpose of detecting the errors in the first place.
> > 
> > Check the magic numbers direct from the buffer before decoding the
> > header.
> 
> Looks good; have you sent this for the kernel yet?
> 
> (I thought we wanted changes to hit kernelspace first) :)

Yes, commit 0f295a214bb7658ca37bd61a8a1f0cd4a9d86c1f.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>