xfs
[Top] [All Lists]

Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 10 Oct 2013 07:41:23 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52548CF2.2040000@xxxxxxxxxxx>
References: <1380510944-8571-1-git-send-email-david@xxxxxxxxxxxxx> <1380510944-8571-3-git-send-email-david@xxxxxxxxxxxxx> <52548CF2.2040000@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 08, 2013 at 05:53:38PM -0500, Eric Sandeen wrote:
> On 9/29/13 10:15 PM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > They were missed in the original patch that was committed.
> 
> I'm not sure it's required in lookup or remove, at least today
> nothing looks at it on those paths, does it?

Correct, but...

> Anyway, matches kernel, at worst the last 2 are harmless:

... matching the kernel code is more important at this point.

> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>