xfs
[Top] [All Lists]

Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 08 Oct 2013 17:53:38 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1380510944-8571-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1380510944-8571-1-git-send-email-david@xxxxxxxxxxxxx> <1380510944-8571-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 9/29/13 10:15 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> They were missed in the original patch that was committed.

I'm not sure it's required in lookup or remove, at least today
nothing looks at it on those paths, does it?

Anyway, matches kernel, at worst the last 2 are harmless:

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>


> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  libxfs/xfs_dir2.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libxfs/xfs_dir2.c b/libxfs/xfs_dir2.c
> index 010c701..96a3c1d 100644
> --- a/libxfs/xfs_dir2.c
> +++ b/libxfs/xfs_dir2.c
> @@ -194,6 +194,7 @@ xfs_dir_createname(
>       memset(&args, 0, sizeof(xfs_da_args_t));
>       args.name = name->name;
>       args.namelen = name->len;
> +     args.filetype = name->type;
>       args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>       args.inumber = inum;
>       args.dp = dp;
> @@ -268,6 +269,7 @@ xfs_dir_lookup(
>       memset(&args, 0, sizeof(xfs_da_args_t));
>       args.name = name->name;
>       args.namelen = name->len;
> +     args.filetype = name->type;
>       args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>       args.dp = dp;
>       args.whichfork = XFS_DATA_FORK;
> @@ -323,6 +325,7 @@ xfs_dir_removename(
>       memset(&args, 0, sizeof(xfs_da_args_t));
>       args.name = name->name;
>       args.namelen = name->len;
> +     args.filetype = name->type;
>       args.hashval = dp->i_mount->m_dirnameops->hashname(name);
>       args.inumber = ino;
>       args.dp = dp;
> 

<Prev in Thread] Current Thread [Next in Thread>