[Top] [All Lists]

Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream

To: Eric Sandeen <sandeen@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 8 Oct 2013 09:21:13 -0500
Cc: <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52535864.8020503@xxxxxxxxxxx>
References: <524AF8AE.5030300@xxxxxxx> <20131007193912.256265551@xxxxxxx> <20131008005317.GU4446@dastard> <52535864.8020503@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 10/07/2013 07:57 PM, Eric Sandeen wrote:
On 10/7/13 7:53 PM, Dave Chinner wrote:
Two tests, please. move all the common parts into common/dump, and
write them as two separate tests. That way we can easily track what
test is failing just by looking at what harness test is failing...

I'm not quite convinced that it's 2 separate tests, TBH.

It's the same root cause; I guess there is a slightly different
outcome because if you hit the same root cause enough times,
you'll segfault.

Multiple DMF offline files are successfully restored but the attrs are lost. I wanted to show/test that case.

I agree with Eric that it is the same root cause but because can occur with successful dumps and does not segfault, Thats why the 2 tests.

That's the only difference in test #2.
(and the segfault isn't fixed AFAIK).

Agreed and I will note that in the test description.


<Prev in Thread] Current Thread [Next in Thread>