xfs
[Top] [All Lists]

Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream

To: rjohnston@xxxxxxx
Subject: Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 8 Oct 2013 12:08:22 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131007193912.256265551@xxxxxxx>
References: <524AF8AE.5030300@xxxxxxx> <20131007193912.256265551@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 07, 2013 at 02:38:35PM -0500, rjohnston@xxxxxxx wrote:
> +# create files for test 1, a large file so the sparse file
> +# is in the next stream.
> +_create_test1_files()
> +{
> +
> +     dd if=/dev/zero of=$SCRATCH_MNT/$DUMPDIR/10MB bs=1MB \
> +             count=10 2>&1 >> $seqres.full | _filter_dd
> +     truncate --size=1t $SCRATCH_MNT/$DUMPDIR/sparse0 2>&1 \
> +             >> $seqres.full

I just noticed that 'truncate' is used here - we don't use that
anywhere else in xfstests, so either you need test for it in
common/config and use $TRUNCATE_PROG, or do like every other test
does and use:

        $XFS_IO_PROG -c "truncate 1t" $SCRATCH_MNT/$DUMPDIR/sparse0 

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>