xfs
[Top] [All Lists]

Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 07 Oct 2013 19:58:48 -0500
Cc: rjohnston@xxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52535864.8020503@xxxxxxxxxxx>
References: <524AF8AE.5030300@xxxxxxx> <20131007193912.256265551@xxxxxxx> <20131008005317.GU4446@dastard> <52535864.8020503@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 10/7/13 7:57 PM, Eric Sandeen wrote:
> On 10/7/13 7:53 PM, Dave Chinner wrote:
>> Two tests, please. move all the common parts into common/dump, and
>> write them as two separate tests. That way we can easily track what
>> test is failing just by looking at what harness test is failing...
> 
> I'm not quite convinced that it's 2 separate tests, TBH.
> 
> It's the same root cause; I guess there is a slightly different
> outcome because if you hit the same root cause enough times,
> you'll segfault.  That's the only difference in test #2.
> (and the segfault isn't fixed AFAIK).

Or to be clearer - I'm not sure that test1 is testing anything
fundamentally different from test2.

-Eric

<Prev in Thread] Current Thread [Next in Thread>