xfs
[Top] [All Lists]

Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream

To: rjohnston@xxxxxxx
Subject: Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 8 Oct 2013 11:53:17 +1100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131007193912.256265551@xxxxxxx>
References: <524AF8AE.5030300@xxxxxxx> <20131007193912.256265551@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 07, 2013 at 02:38:35PM -0500, rjohnston@xxxxxxx wrote:
> Verify extended attributes are not lost after multi-stream
> xfsdump/xfsrestore of wholly-sparse files.  xfsrestore did not
> recognize that if the LAST header was reached with no restoredsz set,
> (i.e the LAST header is the only header), the following warning is
> displayed:
> 
>   "partial_reg: Out of records. Extend attrs applied early."
> 
> and the extended attributes on the current and following restored
> files are lost.
> 
> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>
> 
> ---
>  tests/xfs/350     |  134 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/350.out |    2 
>  tests/xfs/group   |    1 
>  3 files changed, 137 insertions(+)
> 
> Index: b/tests/xfs/350
> ===================================================================
> --- /dev/null
> +++ b/tests/xfs/350
....
> +here=`pwd`
> +tmp=/tmp/$$
> +status=0     # success is the default!

status=1

Test failure should always be the default.


> +}
> +echo "Silence is golden."
> +echo "Starting Test 1" >> $seqres.full
> +_clean_dirs
> +_create_test1_files
> +_set_attrs
> +_do_dump_restore
> +_verify_attrs
> +
> +echo "Starting Test 2" >> $seqres.full
> +_clean_dirs
> +_create_test2_files
> +_set_attrs
> +_do_dump_restore
> +_verify_attrs

Two tests, please. move all the common parts into common/dump, and
write them as two separate tests. That way we can easily track what
test is failing just by looking at what harness test is failing...

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>