xfs
[Top] [All Lists]

Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V3] xfstests: restrict 259 device sizes to multiples of 512
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 8 Oct 2013 11:46:41 +1100
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5250CD80.9090708@xxxxxxxxxxx>
References: <5250CA13.8040006@xxxxxxxxxx> <5250CC9B.50807@xxxxxxxxxxx> <5250CD80.9090708@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Oct 05, 2013 at 09:40:00PM -0500, Eric Sandeen wrote:
> Test 259 tries to make a loop device size which is 1 byte less
> than 4T; losetup now warns that this makes little sense, and
> the warning breaks the test output:
> 
>     +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte 
> sector the end of the file will be ignored.
> 
> The RH QE testcase did originally use loopback, so did
> not in effect test anything other than 512-multiple boundaries.
> 
> Just drop the non-512-byte-multiple cases, they produce
> devices exactly the same size as their 512-byte-multiple
> neighbors.
> 
> (FWIW, this is a regression test for the bug that
> d943b11 mkfs: get size of device properly
> fixed.)
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>