[Top] [All Lists]

[PATCH] xfstests: restrict 259 device sizes to multiples of 512

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfstests: restrict 259 device sizes to multiples of 512
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Sat, 05 Oct 2013 21:25:23 -0500
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
Test 259 tries to make a loop device size which is 1 byte less
than 4T; losetup now warns that this makes little sense, and
the warning breaks the test output:

    +losetup: /mnt/test/259.image: warning: file does not fit into a 512-byte 
sector the end of the file will be ignored.

The RH QE testcase did originally use loopback, so
did not test anything other than 512 boundaries.

Just drop the 1-byte-shy case, because it produces a device
exactly the same size as the 512-bytes-shy case.

(FWIW, this is a regression test for the bug that
d943b11 mkfs: get size of device properly

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

diff --git a/tests/xfs/259 b/tests/xfs/259
index 59eeaca..9c12ccf 100755
--- a/tests/xfs/259
+++ b/tests/xfs/259
@@ -48,7 +48,7 @@ testfile=$TEST_DIR/259.image
 # Test various sizes slightly less than 4 TB
 four_TB=$(_math "2^42")
-for del in 1 512 1024 1025 2048 4096; do
+for del in 512 1024 1025 2048 4096; do
        ddseek=$(_math "$four_TB - $del")
        echo "Trying to make (4 TB - $del) B long xfs fs image"
        rm -f "$testfile"

<Prev in Thread] Current Thread [Next in Thread>