xfs
[Top] [All Lists]

Re: [PATCH 04/16] xfs: decouple log and transaction headers

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/16] xfs: decouple log and transaction headers
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 4 Oct 2013 10:49:52 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20131003145650.GD10316@xxxxxxxxxxxxx>
References: <1380510433-8353-1-git-send-email-david@xxxxxxxxxxxxx> <1380510433-8353-5-git-send-email-david@xxxxxxxxxxxxx> <20131003145650.GD10316@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 03, 2013 at 07:56:50AM -0700, Christoph Hellwig wrote:
> > @@ -33,16 +33,6 @@ struct xfs_log_vec {
> >  #define XFS_LOG_VEC_ORDERED        (-1)
> >  
> >  /*
> > - * Structure used to pass callback function and the function's argument
> > - * to the log manager.
> > - */
> > -typedef struct xfs_log_callback {
> > -   struct xfs_log_callback *cb_next;
> > -   void                    (*cb_func)(void *, int);
> > -   void                    *cb_arg;
> > -} xfs_log_callback_t;
> > -
> > -/*
> 
> Looking at the code I don't think this one needs to be moved as the
> t_logcb field in struct xfs_trans is dead already.  Just remove it in
> a separate patch and this declaration can stay where it is.

Ok, I debated whether to just remove the t_logcb fields, and decided
just to move the declaration on the toss of a coin. I'll just remove
it...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>