xfs
[Top] [All Lists]

Re: [PATCH 04/16] xfs: decouple log and transaction headers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/16] xfs: decouple log and transaction headers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Oct 2013 07:56:50 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1380510433-8353-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1380510433-8353-1-git-send-email-david@xxxxxxxxxxxxx> <1380510433-8353-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> @@ -33,16 +33,6 @@ struct xfs_log_vec {
>  #define XFS_LOG_VEC_ORDERED  (-1)
>  
>  /*
> - * Structure used to pass callback function and the function's argument
> - * to the log manager.
> - */
> -typedef struct xfs_log_callback {
> -     struct xfs_log_callback *cb_next;
> -     void                    (*cb_func)(void *, int);
> -     void                    *cb_arg;
> -} xfs_log_callback_t;
> -
> -/*

Looking at the code I don't think this one needs to be moved as the
t_logcb field in struct xfs_trans is dead already.  Just remove it in
a separate patch and this declaration can stay where it is.

Otherwise this patch looks good to me.

<Prev in Thread] Current Thread [Next in Thread>