xfs
[Top] [All Lists]

Re: [PATCH] xfs: get rid of count from xfs_iomap_write_allocate()

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: get rid of count from xfs_iomap_write_allocate()
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 1 Oct 2013 15:58:40 -0500
Cc: Dave Chinner <dchinner@xxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130929223511.GF26872@dastard>
References: <52480744.10606@xxxxxxxxxx> <20130929223511.GF26872@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Sep 30, 2013 at 08:35:11AM +1000, Dave Chinner wrote:
> On Sun, Sep 29, 2013 at 06:56:04PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu@xxxxxxxxxx>
> > 
> > Get rid of function variable count from xfs_iomap_write_allocate() as
> > it is unused.
> > 
> > Additionally, checkpatch warn me of the following for this change:
> > WARNING: extern prototypes should be avoided in .h files
> > +extern int xfs_iomap_write_allocate(struct xfs_inode *, xfs_off_t,
> 
> Bah, checkpatch should be considered harmful when run on code that
> has been around for years. It's a good guide for new code, but...
> 
> $ git grep extern fs/xfs/xfs*h |wc -l
> 345
> $ git grep extern include/linux/*h |wc -l
> 6878
> $
> 
> .... and the rule of "consistent with existing coding style" when
> adding code to existing files generally trumps any "style errors"
> that checkpatch might warn about.
> 
> > So this patch also remove all extern function prototypes at xfs_iomap.h
> > to suppress it to make this code style in consistent manner in this file.
> 
> Anyway, it's a cleanup patch to begin with, and there's only a few
> of them, so it's not worth complaining about.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfs: get rid of count from xfs_iomap_write_allocate(), Ben Myers <=