xfs
[Top] [All Lists]

Re: [PATCH] xfs: Use kmem_free() instead of free()

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: Use kmem_free() instead of free()
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 1 Oct 2013 10:22:54 -0500
Cc: Thierry Reding <thierry.reding@xxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <524AE39B.3040505@xxxxxxx>
References: <1380638873-5181-1-git-send-email-treding@xxxxxxxxxx> <524AE39B.3040505@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote:
> On 10/01/13 09:47, Thierry Reding wrote:
> >This fixes a build failure caused by calling the free() function which
> >does not exist in the Linux kernel.
> >
> >Signed-off-by: Thierry Reding<treding@xxxxxxxxxx>
> >---
> >  fs/xfs/xfs_log_recover.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> >index 4324058..3979749 100644
> >--- a/fs/xfs/xfs_log_recover.c
> >+++ b/fs/xfs/xfs_log_recover.c
> >@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
> >             "bad number of regions (%d) in inode log format",
> >                               in_f->ilf_size);
> >                     ASSERT(0);
> >-                    free(ptr);
> >+                    kmem_free(ptr);
> >                     return XFS_ERROR(EIO);
> >             }
> >
> 
> Looks good. I will remove the other list items in another patch.
> 
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

Gah.  Build Fail.  Apparently things were getting a little punchy over here.

Applied, and thanks Thierry.

-Ben

<Prev in Thread] Current Thread [Next in Thread>