xfs
[Top] [All Lists]

Re: [PATCH] xfs: Use kmem_free() instead of free()

To: Thierry Reding <thierry.reding@xxxxxxxxx>
Subject: Re: [PATCH] xfs: Use kmem_free() instead of free()
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 01 Oct 2013 10:00:43 -0500
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1380638873-5181-1-git-send-email-treding@xxxxxxxxxx>
References: <1380638873-5181-1-git-send-email-treding@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 10/01/13 09:47, Thierry Reding wrote:
This fixes a build failure caused by calling the free() function which
does not exist in the Linux kernel.

Signed-off-by: Thierry Reding<treding@xxxxxxxxxx>
---
  fs/xfs/xfs_log_recover.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 4324058..3979749 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1585,7 +1585,7 @@ xlog_recover_add_to_trans(
                "bad number of regions (%d) in inode log format",
                                  in_f->ilf_size);
                        ASSERT(0);
-                       free(ptr);
+                       kmem_free(ptr);
                        return XFS_ERROR(EIO);
                }


Looks good. I will remove the other list items in another patch.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>