xfs
[Top] [All Lists]

Re: [PATCH] xfstests/btrfs: do not test btrfs/010 with autodefrag

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests/btrfs: do not test btrfs/010 with autodefrag
From: David Sterba <dsterba@xxxxxxx>
Date: Tue, 1 Oct 2013 16:40:47 +0200
Cc: Liu Bo <bo.li.liu@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130927134544.GI18681@xxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: dsterba@xxxxxxx, Josef Bacik <jbacik@xxxxxxxxxxxx>, Liu Bo <bo.li.liu@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <1379481475-10842-1-git-send-email-bo.li.liu@xxxxxxxxxx> <20130927134544.GI18681@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.21 (2012-12-30)
On Fri, Sep 27, 2013 at 09:45:44AM -0400, Josef Bacik wrote:
> On Wed, Sep 18, 2013 at 01:17:55PM +0800, Liu Bo wrote:
> > btrfs/010 is going to create a fragmented file, however, with autodefrag
> > this is impossible, so just skip the test when we're with autodefrag.
> > 
> > Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx>
> 
> I'd rather you just strip out the autodefrag option if it is there and add it
> back once the test is done (or hell just remove it, mount, and add it back).

I think the test should be skipped if it does not make sense with a
specific mount option rather than temporarily removing it, because then
it looks like the test passes with the option altough it does not.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests/btrfs: do not test btrfs/010 with autodefrag, David Sterba <=