xfs
[Top] [All Lists]

Re: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: V

To: Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Variables Uninitialized
From: Geyslan GregÃrio Bem <geyslan@xxxxxxxxx>
Date: Fri, 27 Sep 2013 15:01:16 -0300
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=VrqDsrmrMr1FRz5/nd0gotp4PDDJ7a4NwZGeNWi4Hv8=; b=qCIk1IXnrWTAXNRsZ7YTulgDdHMlRpxZ0qVCOMoQEi9g4Ql7U4JMixEGB9lxu5zdSs 78DMEyZuI0VPjrfWSxKsmhNeeABC8eynC0cW+Thf+DSsmYye84N53WBBRbq+B+g25V9f MAxFJxJOX0wpulcOFJ2Ud4XtpQSCHW7hn8RO1BJYx04fBhfh89xUXIbOOm3jVG5gHnyG tfV4A7Gaq3HN9/k9rJ19yOj6Xb1Un8dV4T3OdqnnPwVLt1Am+mSFZXDFS6AVGMPbHuC/ gaPLf+CJWStHlGX0igd63DVFPJ6duDN9JobdxLYFXFvNXOvE9BnR7H/ZsYicZFd1+Kt5 IFJg==
In-reply-to: <CAGG-pUQr39G3QiiS=yoDQk+RmVihr59N8Z6Wk5G05QFB=gJF4g@xxxxxxxxxxxxxx>
References: <CAGG-pURO7QrMcU1btzh_RvQkLB=4QFqrLntW3n6BeMfU4iFdUQ@xxxxxxxxxxxxxx> <CAGG-pUQr39G3QiiS=yoDQk+RmVihr59N8Z6Wk5G05QFB=gJF4g@xxxxxxxxxxxxxx>
Hi Maintainers,

I suppose the variables "highstale" and "lowstale" are being used
despite not having been initialized.

File: fs/xfs/xfs_dir2_node.c
Function: xfs_dir2_leafn_add

L491:
> /*
> * Insert the new entry, log everything.
> */
> lep = xfs_dir3_leaf_find_entry(&leafhdr, ents, index, compact, lowstale,
> highstale, &lfloglow, &lfloghigh);

The only place they are started up is within this condition:

L480:
> if (compact)
> xfs_dir3_leaf_compact_x1(&leafhdr, ents, &index, &lowstale,
> &highstale, &lfloglow, &lfloghigh);

So, if it is not compact, both have garbage.

Best Regards.

Geyslan GregÃrio Bem

<Prev in Thread] Current Thread [Next in Thread>