Re: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Variables Uninitialized

[Geyslan GregÃrio Bem <geyslan@xxxxxxxxx>]

Hi Maintainers,

I suppose the variables "highstale" and "lowstale" are being used
despite not having been initialized.

File: fs/xfs/xfs_dir2_node.c
Function: xfs_dir2_leafn_add

L491:
> /*
> * Insert the new entry, log everything.
> */
> lep = xfs_dir3_leaf_find_entry(&leafhdr, ents, index, compact, lowstale,
> highstale, &lfloglow, &lfloghigh);

The only place they are started up is within this condition:

L480:
> if (compact)
> xfs_dir3_leaf_compact_x1(&leafhdr, ents, &index, &lowstale,
> &highstale, &lfloglow, &lfloghigh);

So, if it is not compact, both have garbage.

Best Regards.

Geyslan GregÃrio Bem