xfs
[Top] [All Lists]

[XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Varia

To: Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Variables Uninitialized
From: Geyslan GregÃrio Bem <geyslan@xxxxxxxxx>
Date: Fri, 27 Sep 2013 14:59:12 -0300
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=DhSAIKFJn+bTiL5TLi059vEiGRLTjsgfb77qopi6Cso=; b=nynuDMwqQeWCKRMLZ6HLZLgptKGVA+pwuIymD4VFhdl3c3p9IxN6ZAUFC/CPf57lyb xMBgETqUnFbfS/QATm+t2nZb4E3I9lr/dQ+qkt2UzPHgDVCQlYvaZhsZILbsyCQrtNRr QK14+IOkHzCB+peJpYlBBwptYm2UP8z/Us95Foh6VPUpR35kCAILRGti6GKJZxPZOcc4 koQK4RPWRmi0zcjzZ5GVQsvjE2dg+djOomi9BlhyU87NpiLopvnw57ebit3EzYicm/HX 4IMKlb3st0HS64GxFFexjxPgnNq2DW/BUMIsBgqSoBQbUYBpl7P9dlvDMxZrYHX+WPzK hvvQ==
In-reply-to: <CAGG-pURO7QrMcU1btzh_RvQkLB=4QFqrLntW3n6BeMfU4iFdUQ@xxxxxxxxxxxxxx>
References: <CAGG-pURO7QrMcU1btzh_RvQkLB=4QFqrLntW3n6BeMfU4iFdUQ@xxxxxxxxxxxxxx>

Hi Maintainers,

I suppose the variables "highstale" and "lowstale" are being used despite not having been initialized.

File: fs/xfs/xfs_dir2_node.c
Function: xfs_dir2_leafn_add

L491:
> /*
> * Insert the new entry, log everything.
> */
> lep = xfs_dir3_leaf_find_entry(&leafhdr, ents, index, compact, lowstale,
> highstale, &lfloglow, &lfloghigh);

The only place they are started up is within this condition:

L480:
> if (compact)
> xfs_dir3_leaf_compact_x1(&leafhdr, ents, &index, &lowstale,
> &highstale, &lfloglow, &lfloghigh);

So, if it is not compact, both have garbage.

Best Regards.

Geyslan GregÃrio Bem

<Prev in Thread] Current Thread [Next in Thread>