| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix memory leak in xfs_dir2_node_removename |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 27 Sep 2013 12:48:42 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5245B5E5.7000206@xxxxxxxxxxx> |
| References: | <20130927130140.640252809@xxxxxxx> <5245B5E5.7000206@xxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 09/27/13 11:44, Eric Sandeen wrote: On 9/27/13 8:01 AM, Mark Tinguely wrote:Free the memory pointed to by state before returning on error from xfs_dir2_node_removename.c Signed-off-by: Mark Tinguely<tinguely@xxxxxxx> --- Found by Coverity (134681) in userspace, same patch applies there also.Heh, looks like that one has been around since the dawn of time, thanks. Reviewed-by: Eric Sandeen<sandeen@xxxxxxxxxx> how do we handle the matching userspace fixes, separate patch to be explicit? Wait for the next syncup? Thanks, -Eric <patch delete> Good question. The user space should be kept up to date with the kernel.Since the patches will be identical except the directory name, I was hoping to submit one copy. But I am not trying to invent a policy, just being lazy. --Mark. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: fix memory leak in xlog_recover_add_to_trans, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: btrfs/015 regression test for prealloc with balance, Zach Brown |
| Previous by Thread: | Re: [PATCH] xfs: fix memory leak in xfs_dir2_node_removename, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs: fix memory leak in xfs_dir2_node_removename, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |