xfs
[Top] [All Lists]

[PATCH] xfs: fix memory leak in xlog_recover_add_to_trans

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: fix memory leak in xlog_recover_add_to_trans
From: tinguely@xxxxxxx
Date: Fri, 27 Sep 2013 09:00:55 -0500
Delivered-to: xfs@xxxxxxxxxxx
User-agent: quilt/0.51-1
Free the memory in error path of xlog_recover_add_to_trans().
Normally this memory is freed in recovery pass2, but is leaked
in the error path.

Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
---
Found by Coverity (134683) in userspace, same patch applies there
also.
 fs/xfs/xfs_log_recover.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/fs/xfs/xfs_log_recover.c
===================================================================
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -1585,6 +1585,7 @@ xlog_recover_add_to_trans(
                "bad number of regions (%d) in inode log format",
                                  in_f->ilf_size);
                        ASSERT(0);
+                       free(ptr);
                        return XFS_ERROR(EIO);
                }
 


<Prev in Thread] Current Thread [Next in Thread>