[Top] [All Lists]

Re: [PATCH v2] xfsprogs: fix potential memory leak in verify_set_primary

To: Li Zhong <zhong@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfsprogs: fix potential memory leak in verify_set_primary_sb()
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 25 Sep 2013 08:26:44 -0500
Cc: xfsprogs <xfs@xxxxxxxxxxx>, Chandra Seetharaman <sekharan@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1380094327.2526.5.camel@ThinkPad-T5421>
References: <1379829679.4089.2.camel@ThinkPad-T5421> <5241E125.7010902@xxxxxxx> <1380094327.2526.5.camel@ThinkPad-T5421>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/25/13 02:32, Li Zhong wrote:
This patch tries to fix CID 997012, 997013 and 997014 reported by Coverity scan,
as suggested by sekharan.

v2: as Mark pointed out, out in the for loop before also needs list to
be freed. Also remove out lable as it is not referenced any more.

Signed-off-by: Li Zhong<zhong@xxxxxxxxxxxxxxxxxx>

Thank-you, that looks great.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>