xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error.

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 25 Sep 2013 10:31:08 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130924205949.GK1935@xxxxxxx>
References: <1380002476-18839-1-git-send-email-david@xxxxxxxxxxxxx> <1380002476-18839-2-git-send-email-david@xxxxxxxxxxxxx> <20130924153324.GF1935@xxxxxxx> <20130924203232.GA26872@dastard> <20130924205949.GK1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 24, 2013 at 03:59:49PM -0500, Ben Myers wrote:
> Hi Dave,
> 
> On Wed, Sep 25, 2013 at 06:32:32AM +1000, Dave Chinner wrote:
> > On Tue, Sep 24, 2013 at 10:33:24AM -0500, Ben Myers wrote:
> > > ...but it looks like your fix is in xfs_bdstrat_cb, which wouldn't have 
> > > been
> > > involved in the stack you posted above.  What am I missing?
> > 
> > That the first hunk that changes xfs_bioerror_relse() fixes the bug
> > that caused the assert failure through xfsbdstrat().
> 
> *blink*
> 
> All I see in that first hunk are changes to comments.  The second hunk seems 
> to
> contain the only functional change, highlighted above.

You are right - it should not be reliably fixing the failure I'm
seeing. I'm sure there was something else in this patch originally -
I'll go back and check.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>