xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix node forward in xfs_node_toosmall

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: fix node forward in xfs_node_toosmall
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Mon, 23 Sep 2013 17:34:41 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=vjNhNfs8w4VQsgGzR+qPXV5wLbd2Q60C/J9ep2F3EZs=; b=rCT1m7fn/8sfbHuClr8tlD8+AVqhMjvAp4glaOQ/KqmPJqNKzqGRUQTQI+LfmZdB+s EOCbFU+TKCEulTQ/MtYig/MqaTbUaxpSwDet0R1iHANNqNQtO6Oujgc9dxDBXHtMs7DL oNjZY1ouxlfKvau3Odn7zy5VzrIOZ+Vy6juWg64fV9V5TN5JblXsYB1DJS2PkLtu5kbD 6uAsRah4YXpLJU3f8Ezb3difg/LfUMc89tMP2+U3Lfy4gVJDooCPWm/mbEVsKHZqa1e1 P2UEtH73p+Gf/vzNlTtt3G3tG4SGYiVhnps0yYUXFcdRdT7FtKQaN9sVgz2zREZclVJc kgxg==
In-reply-to: <20130920220519.585903357@xxxxxxx>
References: <20130920220519.585903357@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 09/20/2013 06:05 PM, Mark Tinguely wrote:
> Commit f5ea1100 cleans up the disk to host conversions for
> node directory entries, but because a variable is reused in
> xfs_node_toosmall() the next node is not correctly found.
> If the original node is small enough (<= 3/8 of the node size),
> this change may incorrectly cause a node collapse when it should
> not. That will cause an assert in xfstest generic/319:
> 
>    Assertion failed: first <= last && last < BBTOB(bp->b_length),
>    file: /root/newest/xfs/fs/xfs/xfs_trans_buf.c, line: 569
> 
> Keep the original node header to get the correct forward node.

This works for xfstests generic/319 on 32-bit x86.  The xfstests 
run was okay, with a lockdep in the middle and a crash in xfs/300. 
Neither the lockdep nor the crash could reproduced by running 
individual tests one by one.

generic/319 itself fails only because it couldn't find its 
_cleanup routine.  I'm not sure if I'm using v1 or v2 of 
generic/319.

The kernel is set to the commit just before the latest aio-next 
merge, which is causing severe problems here.  xfsprogs was the 
latest production xfsprogs because my copy of xfstests is having 
trouble checking v4 XFS filesystems otherwise.

Will test xfs_node_toosmall patch v2 once I get home.

Thanks!

Michael

<Prev in Thread] Current Thread [Next in Thread>