xfs
[Top] [All Lists]

Re: [PATCH] xfstest/btrfs/001: fix the misuse of subvolume set-default

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstest/btrfs/001: fix the misuse of subvolume set-default
From: Liu Bo <bo.li.liu@xxxxxxxxxx>
Date: Mon, 23 Sep 2013 22:37:56 +0800
Cc: linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130923131746.GA18681@xxxxxxxxxxxxxxxxxxxxx>
References: <1379926049-22135-1-git-send-email-bo.li.liu@xxxxxxxxxx> <20130923131746.GA18681@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: bo.li.liu@xxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 23, 2013 at 09:17:46AM -0400, Josef Bacik wrote:
> On Mon, Sep 23, 2013 at 04:47:29PM +0800, Liu Bo wrote:
> > The command is
> > btrfs subvolume set-default <subvolid> <path>.
> > 
> > It uses @subvolid to control the default subvolume and
> > @subvolid=0 has always been parsed into FS_TREE no matter
> > what subvolume @path points to.
> > 
> > So in order to set a subvolume to the default one, we need
> > to get the id of this subvolume first.
> > 
> > Also fix a typo:
> > s/sbuvolid/subvolid/g
> > 
> > Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx>
> 
> Sent a patch for this already.  Thanks,

oops, sorry I should have noticed that, any chance to fold the typo fix
into your patch?

-liubo

<Prev in Thread] Current Thread [Next in Thread>