xfs
[Top] [All Lists]

Re: [PATCH v2 4/4] xfs: clean up xfs_inactive() error handling, kill VN_

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2 4/4] xfs: clean up xfs_inactive() error handling, kill VN_INACTIVE_[NO]CACHE
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 20 Sep 2013 09:50:38 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1379618121-35105-5-git-send-email-bfoster@xxxxxxxxxx>
References: <1379618121-35105-1-git-send-email-bfoster@xxxxxxxxxx> <1379618121-35105-5-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 19, 2013 at 03:15:21PM -0400, Brian Foster wrote:
> The xfs_inactive() return value is meaningless. Turn xfs_inactive()
> into a void function and clean up the error handling appropriately.
> Kill the VN_INACTIVE_[NO]CACHE directives as they are not relevant
> to Linux.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>