xfs
[Top] [All Lists]

Re: [PATCH] xfstests: unify apostrophes in output files

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: unify apostrophes in output files
From: Ilya Dryomov <idryomov@xxxxxxxxx>
Date: Thu, 19 Sep 2013 19:54:52 +0300
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nA7SQFW8W1s9NMmqqjTpOJ61ydFhenWJB757M8QbDQs=; b=hrDxvAcLnukZ4TBzQdz3BsNKW7/r+NTkF2+Ix/FdReQpFaeuqY+pc1wVP+H3meLGjs yCjl9CHaWfjOB4Oem/BpG3wBUKFtSR3fps5tSIsk5VFjom92Zo0NaTRu8EOC1a1DUen4 9WNuDXPDooCp8ikcSPpXmcaBwvucLhpLu8U8V44IcBe0Z2f0VLXfuA8UnM7DW5ywjdai G8PsGqcFS0/MpJeP78NrwN6DREtwVJM2Iahuy1C3EcaWpKNEIqfqKTbfleQ3HBgV3Mf6 ahijG/t6AOr9IRmOHLopJOV/TunTno/VkJatREYN1hU69B2HaZgJpHA06jnvgKx12uqW wGDQ==
In-reply-to: <523B2455.4000609@xxxxxxxxxx>
References: <1379536166-19232-1-git-send-email-jbacik@xxxxxxxxxxxx> <20130918211325.GB4330@dastard> <523B2455.4000609@xxxxxxxxxx>
On Thu, Sep 19, 2013 at 7:20 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> xfstests: unify apostrophes in output files
>
> From: Tomas Racek <tracek@xxxxxxxxxx>
>
> With coreutils v8.16 the style of apostrophes changed from `word' to
> 'word'. This is breaking some tests which use the older form.
>
> This commit introduces function changes the golden output of the
> affected tests and introduces a filter for the older style output.
>
> [dchinner: modified to use a global filter in check rather than
> per-test filters]
>
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> (Resending as proper top-level, modified, reviewed patch --Eric)
>
>  check                 |  4 ++++
>  common/config         |  1 +
>  tests/generic/193.out | 16 ++++++++--------
>  tests/generic/230.out |  8 ++++----
>  tests/generic/235.out |  2 +-
>  tests/generic/245.out |  2 +-
>  tests/generic/294.out |  8 ++++----
>  tests/generic/306.out |  2 +-
>  tests/xfs/103.out     |  2 +-
>  tests/xfs/200.out     |  2 +-
>  10 files changed, 26 insertions(+), 21 deletions(-)
>
> diff --git a/check b/check
> index 4085eae..ba7fd21 100755
> --- a/check
> +++ b/check
> @@ -478,6 +478,10 @@ do
>                 echo " - no qualified output"
>                 err=true
>             else
> +
> +               # coreutils 2.16+ changed quote formats in error messages from

Should that be 8.16+?

Thanks,

                Ilya

<Prev in Thread] Current Thread [Next in Thread>