xfs
[Top] [All Lists]

Re: [BULK] Re: [PATCH] xfstests: introduce _filter_backtick

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [BULK] Re: [PATCH] xfstests: introduce _filter_backtick
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Thu, 19 Sep 2013 09:36:47 -0400
Cc: Josef Bacik <jbacik@xxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1379597810; bh=SLfU5GBhgaUC4kPQsiQZe995VMX9EcQdWm6NsBvxnCY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=B7xgJI2Y6CBCAn2h42HotPMW0askjpoQQ2d4GaPYkWtX9DH6SmZ/bFN7s/+CoDhtL 4rESMpfjh3NDSUtQN81+LUtAPC6DT9yqAI7+LFqWBQWC1oDiX9v37yx/vC/c3n2K7v 9PYQfsj4w5iWFYmjSImcdIiQPbjMojFCznLJrjKo=
In-reply-to: <20130918211325.GB4330@dastard>
References: <1379536166-19232-1-git-send-email-jbacik@xxxxxxxxxxxx> <20130918211325.GB4330@dastard>
User-agent: Mutt/1.5.21 (2011-07-01)
On Thu, Sep 19, 2013 at 07:13:25AM +1000, Dave Chinner wrote:
> On Wed, Sep 18, 2013 at 04:29:26PM -0400, Josef Bacik wrote:
> > Apparently the GNU guys decided to change their error output from something 
> > like
> > 
> > Error `Error message'
> > 
> > To
> > 
> > Error 'Error message'
> > 
> > So to fix this I've introduced _filter_backtick which will change any ` to 
> > ' and
> > then changed the output of the tests that were failing for me because of 
> > this
> > output.  I tested this on a new box that has the new output and an old box 
> > which
> > has the old output and it appears to fix the issue.  Thanks,
> > 
> > Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> 
> That's just leaving a landmine behind, and it doesn't catch all the
> tests that need updating. This approach was floated here:
> 
> http://oss.sgi.com/archives/xfs/2013-05/msg00312.html
> 
> And my response was to add a global filter to the .check file so it
> doesn't leave a landmine. Indeed, I have a local version on tomas'
> patch that I modified in May does just that:
> 
> --- a/check
> +++ b/check
> @@ -477,6 +477,10 @@ do
>                 echo " - no qualified output"
>                 err=true
>             else
> +
> +               # coreutils 2.16+ changed quote formats in error messages from
> +               # `foo' to 'foo'. Filter old versions to match the new 
> version.
> +               sed -i "s/\`/\'/g" $tmp.out
>                 if diff $seq.out $tmp.out >/dev/null 2>&1
>                 then
>                     if $err
> 
> I also discovered that for some reason LANG=C is not sufficient for
> all cases to make the quoting behaviour consistent. i.e. I
> needed to set LC_ALL=C so that it didn't use weird UTF-8 encodings
> for the quotes instead of a simple backtick.
> 
> Full patch below.

Excellent, what is holding this patch up then if it was proposed in May and you
are ok with it?  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>