xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: initialize filetype for lost+found creation

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfsprogs: initialize filetype for lost+found creation
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 18 Sep 2013 16:04:42 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <523A135D.7030509@xxxxxxx>
References: <52388C61.1000001@xxxxxxxxxxx> <523A135D.7030509@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 9/18/13 3:55 PM, Mark Tinguely wrote:
> On 09/17/13 12:07, Eric Sandeen wrote:
>> If we create lost+found make sure it's got the proper filetype.
>>
>> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
>> ---
>>
>> (sorry, untested, not sure how to force creation when I can't use
>> xfs_db to craft a filesystem that needs lost+found)
> 
> The {lib}xfs_dir_lookup() doesn't use the field - just like extended 
> attributes use xfs_names but it won't use the field entry, but it does not 
> hurt to have it initialized to something.

Thanks for the review - just FWIW, I was thinking that it needs
to be initialized so that when created, it is created with the proper
type, rather than random stack noise.

It seems, though, that we're still missing bits in libxfs to actually
write the types to disk; I'll look into that.

Thanks,
-Eric

> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>