xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: don't leak root inode reference

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH v2] xfs: don't leak root inode reference
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 18 Sep 2013 13:13:02 +1000
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130910231122.GY1935@xxxxxxx>
References: <20130826204730.GZ7153@xxxxxxx> <20130826212423.GX6023@dastard> <20130827212558.GY5262@xxxxxxx> <20130827220833.GY6023@dastard> <20130910231122.GY1935@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 10, 2013 at 06:11:22PM -0500, Ben Myers wrote:
> Ok.  Lets try this.  ;)
> 
> xfs: remove usage of is_bad_inode
> 
> XFS never calls mark_inode_bad or iget_failed, so it will never see a
> bad inode.  Remove all checks for is_bad_inode because they are
> unnecessary.
> 
> Signed-off-by: Ben Myers <bpm@xxxxxxx>

Looks good to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>